[mamba-content-trust] Add integration test #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hind-M
added
the
release::enhancements
-Add test for mamba-content-trust (mamba client side) using conda-content-trust (server side) -Add missing install with pip (to fix)
| @@ -32,11 +32,11 @@ namespace mamba | |||
|
|
|||
| explicit RepoCheckerStore(repo_checker_list checkers); | |||
|
|
|||
| [[nodiscard]] auto find_checker(const Channel& chan) const -> const RepoChecker*; | |||
There was a problem hiding this comment.
Why removing the const here? It looks legit. Same question for methods below.
There was a problem hiding this comment.
Yes it was legit until I realized that the trusted_channels in Context don't handle more that one item (giving errors if the first one is not the correct/used one). And that's because generate_index_checker() is fetching the root and delegation roles files and was called here (when populating the RepoCheckerStore and before knowing if the corresponding channel will be used) but is now moved to here. And since it's not const the RepoChecker and these methods can't be anymore.
JohanMabille
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mamba-content-trust(mamba client side) usingconda-content-trust(server side)trusted_channelsin context not working with more than one itemrepo_signed(generated when running the script)