Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy error from rattler_repodata_gateway::fetch #520

Closed
wolfv opened this issue Feb 7, 2024 · 0 comments · Fixed by #560
Closed

Noisy error from rattler_repodata_gateway::fetch #520

wolfv opened this issue Feb 7, 2024 · 0 comments · Fixed by #560
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wolfv
Copy link
Member

wolfv commented Feb 7, 2024

When fetching repodata it's "OK" if the target architecture is missing - the only required file is the noarch/repodata.json basically.

However, fetch_repodata returns a NotFound error for non-noarch files. The problem is that this is logged through the instrument attribute on the fetch_repo_data function and pops up in the logs (e.g. in rattler-build).

I am wondering if we could either disable logging an error for this particular error or if we should return a None instead.

@baszalmstra baszalmstra added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants