Add libsolv_rs #243
Add libsolv_rs #243
Conversation
aochagavia
force-pushed
the
add-libsolv-rs
branch
from
a075b36
to
79a266b
Compare
|
Something that we might be interested in is to compile |
crates/libsolv_rs/src/solver/mod.rs
Outdated
| ) -> Result<u32, Problem> { | ||
| level += 1; | ||
|
|
||
| println!( |
There was a problem hiding this comment.
Should we move to tracing::info! here? Or debug!.
There was a problem hiding this comment.
I'm postponing that because it's a fairly mechanical change and I want to make sure all the truly important stuff is done first
| self.pool | ||
| .resolve_solvable_inner(literal.solvable_id) | ||
| .display() | ||
| ); |
There was a problem hiding this comment.
Just as a future idea - this would probably the place to check for a time-budget, right?
There was a problem hiding this comment.
You mean giving up after a given amount of time? In my eyes the best place for that would be Solver::resolve_dependencies, which is using Solver::set_propagate_learn
There was a problem hiding this comment.
Yeah, like setting a limit of 1 sec, or 10'000 iterations ...
crates/rattler_solve/Cargo.toml
Outdated
| @@ -23,8 +23,10 @@ url = "2.4.0" | |||
| hex = "0.4.3" | |||
| tempfile = "3.6.0" | |||
| cfg-if = "1.0.0" | |||
| libsolv_rs = { version = "0.1.0", path = "../libsolv_rs" } | |||
There was a problem hiding this comment.
Ideally we put both implementations behind feature flags.
aochagavia
force-pushed
the
add-libsolv-rs
branch
3 times, most recently
from
3956489
to
ce24cf0
Compare
aochagavia
force-pushed
the
add-libsolv-rs
branch
from
ce24cf0
to
ba7689b
Compare
aochagavia
force-pushed
the
add-libsolv-rs
branch
from
cb8c03a
to
6ce282b
Compare
No description provided.