fix: make topological sorting support fully cyclic dependencies #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the graph of dependencies only consisted of a directed cycle,
sort_topologically
returned an empty list. This was an issue when trying to sort the dependencies of an environment containing Python 3.12 and Pip on MacOS as both depend on each other. See the relevant section of the repodata from conda forge:Even though topological sorting theoretically requires a DAG as its input, the existing implementation of
sort_topologically
already handled directed cycles just not the case where all the nodes were part of such cycles.The fix is that if we can't find any root nodes, we start cycle detection from a random (the first in the given list) node.