Continue code refactor #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyspec
commented
Oct 24, 2019
zyspec
commented
- Refactoring code to utilize objects for access
- improve var sanitation using Xmf\Request
- minor HTML code style improvements
Code cleanup - fix regression bug
* use $helper for file access * use Owner object for dB access * PhpDoc and comment updates
* improve input var sanitation using Xmf\Request * slight improvement in HTML style
* Change from Request::getString() to Request::getCmd() on 'op input * load 'common' language file instead of non-existant 'feedback' file * Minor HTML style cleanup
zyspec
referenced
this pull request
in zyspec/pedigree
Oct 24, 2019
Merge pull request XoopsModules25x#8 from zyspec/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.