Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby support #4

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

JRuby support #4

wants to merge 1 commit into from

Conversation

headius
Copy link

@headius headius commented Oct 11, 2023

Add support for RBTree on JRuby.

@headius
Copy link
Author

headius commented Oct 11, 2023

This will solve knu/sorted_set#7 once complete.

@mame
Copy link
Owner

mame commented Oct 13, 2023

Please let me know when your patch is ready. Since this is a very large code addition, I would like to ask the author and maintainer, OZAWA Takuma, to make a decision. I am just helping him, and this public mirror repository is just for minor fixes and to make it easier for me to do the release work.

BTW, is there an option to distribute it as a separate gem, such as rbtree-java gem? (I am not familiar with JRuby's gems)

@headius
Copy link
Author

headius commented Feb 7, 2024

I managed to get a lot of this implemented, but the methods that expose red/black tree internals are a bit harder to emulate atop this library. Example: left/right boundaries, shift and pop... difficult to implement given the complexity of this concurrent red/black tree impl.

A port of the C dict logic would obviously map exactly, but not have the same concurrency characteristics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants