-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow pulling helmfile releases from new helmfile repository #40
chore: allow pulling helmfile releases from new helmfile repository #40
Conversation
…bump default versions of all tools
Ah, I realize the problem now: I forgot to include |
Actually, no, there are more problems. I guess in my excitement over the new release I didn't realize they'd also switched to uploading tarballs rather than binaries, and also have changed the filename format. Having a single action that supports both the old and new repositories may be a bit more cumbersome than I initially thought. |
Thank you for the pull request.
|
I was able to download it from this URL with curl.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lack of arguments for semvercompare
was the cause of the CI error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. Can you push dist/index.js
as well?
Done. I don't think I will ever learn to remember to rebuild generated files before pushing 🤦♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also bumps the default versions of all tools.
Uses the
semver-compare
library to check whether we are installing version 0.145.0 or later; if so, we use the new repository. Otherwise, we use the old repository.