Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content model and enum related bugs. #36

Merged
merged 25 commits into from
Mar 27, 2022
Merged

Fix content model and enum related bugs. #36

merged 25 commits into from
Mar 27, 2022

Conversation

rvuistin
Copy link
Contributor

@rvuistin rvuistin commented Mar 18, 2022 •
edited
Loading

I have added some unit tests in ContentModelCodeGenTests, ContentModelRuntimeTests and EnumsCodeGenTest

All tests are green and the code generated for a custom application which contains very complex schemas is now functional.

@rvuistin rvuistin changed the title The content model for a type derived by restriction should be inherited. Fix content model for a type derived by restriction + generate content model for complex grouping. Mar 18, 2022
@rvuistin rvuistin changed the title Fix content model for a type derived by restriction + generate content model for complex grouping. Fix content model code generation and runtime management. Mar 20, 2022
@rvuistin rvuistin changed the title Fix content model code generation and runtime management. Fix composite content model code generation and runtime management. Mar 20, 2022
This was referenced Mar 22, 2022
Closed
Closed
@rvuistin rvuistin changed the title Fix composite content model code generation and runtime management. Fix content model related bugs. Mar 22, 2022
@mamift
Copy link
Owner

mamift commented Mar 22, 2022

Hello, are you able to increment the version number in LinqToXsd/LinqToXsd.csproj?

@rvuistin
Copy link
Contributor Author

Hi Muhamamd,
I'm still working on some enum issues. I hope to finish today.
I will increment the versions (XObjectsCore is concerned too) when I finish.
Roger

@mamift
Copy link
Owner

mamift commented Mar 24, 2022

Ok sure.

@rvuistin
XObjectsCore: add 'LocalEnumSuffix'.
9e94200
@rvuistin
XObjectsCode: work out global/nested enum management.
740fa40
@rvuistin
XObjectsTests: implement code generation tests for enum types.
c917b20
@rvuistin
Schemas: add a script to generate code for existing schemas.
c7b63bb 
- skip schemas which trigger exceptions during code generation.
- skip schemas which generate erros during compilation.
@rvuistin
XObjectsTests: adapt some unit tests to match last generated code.
1751c05
@rvuistin
Modernize build system...
ff3578b 
- use Directory.Build.props and Version.props to share project information.
- disable nuget package generation in debug mode.
@rvuistin rvuistin changed the title Fix content model related bugs. Fix content model and enum related bugs. Mar 25, 2022
@rvuistin
Copy link
Contributor Author

Hi Muhammad,

That’s it for now.
The version (3.2.2) is now centralized in the Version.props file for all projects (see my last commit)

Some stuff to review...

@rvuistin
Factorize build system...
6706ed2 
- remove redundant or unused code.
- centralize documentation management.
- hide additional documentation warnings.
- fix ambigous documentation cref.
@rvuistin
Copy link
Contributor Author

The build scripts needed a refresh. It’s done.

  • most properties are now centralized in the Directory.Build.* scripts.
  • same for the version located in the Version.props script. If necessary, it can be overloaded in the project itself.

The LinqToXsd tool is now ready to be migrated to net6...

@mamift
Copy link
Owner

mamift commented Mar 26, 2022

I'm happy with the changes. Ready to merge?

@rvuistin
Copy link
Contributor Author

I have changed the vmImage to windows-2022 in the azure-pipelines.yml to support .NET6 but the check still fails.
Do you understand what's wrong with it ? I've never used azure pipelines before...

@rvuistin
Copy link
Contributor Author

rvuistin commented Mar 27, 2022 •
edited
Loading

I'm happy with the changes. Ready to merge?

Other than that azure pipelines thing, yeah.

@mamift mamift merged commit fce626d into mamift:master Mar 27, 2022
@mamift
Copy link
Owner

mamift commented Mar 27, 2022

I was able to fix the pipeline issue, but was unable to run another rerun of the PR check for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvuistin @mamift