Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project layout? #19

Closed
TheBestPessimist opened this issue Feb 7, 2022 · 4 comments · Fixed by #20
Closed

Update project layout? #19

TheBestPessimist opened this issue Feb 7, 2022 · 4 comments · Fixed by #20

Comments

@TheBestPessimist
Copy link
Contributor

TheBestPessimist commented Feb 7, 2022

Hello

I'm trying to run the code locally and the way it is now, it involves a lot of manual work to make it work.
Would you consider accepting a Pull Request where I add gradle for dependency management, and also update he folder structure a bit?

@Mamiglia
Copy link
Owner

Mamiglia commented Feb 7, 2022

Yes! In fact I have no experience with Maven, Gradle and such. I would really appreciate any contribution! Though as you can see right now the code doesn't work because we're in the middle of a big update and rework (I should've done this in a branch I know) so it's normal that right now the code doesn't work out of the box

@TheBestPessimist
Copy link
Contributor Author

okay. i will try to create the simplest of gradle configurations :)

@TheBestPessimist
Copy link
Contributor Author

also, can you give me a commit hash (from the past) where the app works successfully, so that i can try there and make sure everything works as expected?

Lastly: do you by any chance use intellij Idea? i highly suggest it!

@Mamiglia
Copy link
Owner

Mamiglia commented Feb 7, 2022

I just reverted the main branch to the last working commit, now all the new rework is in the branch structure-rework, so the current last commit (2 Jan 2022 104d24a) works. I do use Intellij Idea already, but it seems I can't make the best use ot it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants