Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log error message when dictionary file does not exist #109

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

mammothb
Copy link
Owner

@mammothb mammothb commented Dec 8, 2021

  • Log error message when corpus/dictionary files is not found in create_dictionary(), load_dictionary(), and load_bigram_dictionary().

Note: chose to log error instead of raising exception to match behavior of the original project.

@mammothb mammothb added the enhancement New feature or request label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #109 (b0bf4e2) into master (84689da) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #109   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          820       825    +5     
  Branches       196       196           
=========================================
+ Hits           820       825    +5     
Impacted Files Coverage Δ
symspellpy/symspellpy.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84689da...b0bf4e2. Read the comment docs.

@mammothb mammothb merged commit 2474650 into master Dec 8, 2021
@mammothb mammothb deleted the feat-log_error_when_file_not_found branch December 8, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant