Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ForwardMessageBuilder easier to use for Java, close #1087 #1089

Merged
merged 3 commits into from Mar 22, 2021
Merged

Make ForwardMessageBuilder easier to use for Java, close #1087 #1089

merged 3 commits into from Mar 22, 2021

Conversation

Him188
Copy link
Member

@Him188 Him188 commented Mar 10, 2021

No description provided.

@Him188 Him188 added the t:enhancement 类型: 现有功能上的优化 label Mar 10, 2021
@Him188 Him188 added this to the 2.6.0 milestone Mar 10, 2021
@Him188 Him188 requested a review from Karlatemp March 10, 2021 02:32
@Him188 Him188 linked an issue Mar 10, 2021 that may be closed by this pull request
为 ForwardMessageBuilder 添加 Java 友好方法并更新文档 #1087
Closed
Karlatemp
Karlatemp reviewed Mar 10, 2021
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 也可以使用 builder.named(123456789L, "Nick").says(....); 调用 KotlinDSL 的方法, 可以在注释中说明

@Him188
Copy link
Member Author

Him188 commented Mar 10, 2021

Java 也可以使用 builder.named(123456789L, "Nick").says(....); 调用 KotlinDSL 的方法, 可以在注释中说明

感觉没有 add 好，还是首选标准的方式

@Him188 Him188 requested a review from Karlatemp March 18, 2021 00:57
@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Mar 18, 2021
@Him188 Him188 changed the base branch from 2.6 to dev March 22, 2021 03:20
@Him188 Him188 merged commit bf47ab4 into dev Mar 22, 2021
@Him188 Him188 deleted the him188/forward_builder branch March 22, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
t:enhancement 类型: 现有功能上的优化 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

为 ForwardMessageBuilder 添加 Java 友好方法并更新文档
2 participants
@Him188 @Karlatemp