New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename RichMessageOrigin
to MessageOrigin
#1116
Conversation
是否需要像以前一样先保留一段时间的二进制兼容(已经无法使用)再彻底删除? |
似乎不容易提供兼容 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public class MessageOrigin( | |
/** | |
* 原 [RichMessage]. | |
*/ | |
public val origin: @Polymorphic RichMessage, |
如果要重命名为 MessageOrigin
, 此处 origin
类型也应该随之修改
那就不容易改了, any suggestions? |
改成 Reason: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不过原来序列化后 type: "RichMessageOrigin"
的反序列化会不会出错,直接序列化 MessageChain
的可能不知道 RichMessageOrigin
的存在
会出错, 那可以写一个反序列化兼容层 |
…ingleMessage`; Rename `RichMessageKind` to `MessageOriginKind`
5c98b5c
to
a3a2e00
Compare
发现其实在 2.3 就没有提供序列化支持... |
为了添加
Dice
的 origin可能有更好的命名, 姑且先改叫
MessageOrigin