Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign MultiMsg #1667

Merged
merged 4 commits into from Nov 16, 2021
Merged

Redesign MultiMsg #1667

merged 4 commits into from Nov 16, 2021

Conversation

Karlatemp
Copy link
Member

@Karlatemp Karlatemp commented Nov 12, 2021 •
edited by Him188

@Karlatemp Karlatemp added t:enhancement 类型: 现有功能上的优化 t:feature 类型: 新特性 x:protocol 属性: 协议相关 N 优先级: 一般 labels Nov 12, 2021
@Karlatemp Karlatemp added this to the 2.9.0-M1 milestone Nov 12, 2021
@Karlatemp Karlatemp mentioned this pull request Nov 12, 2021
Closed
Him188
Him188 reviewed Nov 14, 2021
View reviewed changes
mirai-core/src/commonMain/kotlin/contact/GroupImpl.kt Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/message/MultiMsgUploader.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/message/MultiMsgUploader.kt Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/network/protocol/data/richstatus/RichStatus.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/network/protocol/data/richstatus/RichStatus.kt Outdated Show resolved Hide resolved
mirai-core-utils/src/commonMain/kotlin/Resources.kt Outdated Show resolved Hide resolved
mirai-core-utils/src/commonMain/kotlin/Resources.kt Show resolved Hide resolved
mirai-core-utils/src/commonMain/kotlin/Resources.kt Show resolved Hide resolved
mirai-core-utils/src/commonMain/kotlin/Resources.kt Outdated Show resolved Hide resolved
mirai-core-utils/src/commonMain/kotlin/Resources.kt Outdated Show resolved Hide resolved
sandtechnology
sandtechnology reviewed Nov 14, 2021
View reviewed changes
Copy link
Collaborator

@sandtechnology sandtechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加了点命名建议（

mirai-core/src/commonMain/kotlin/network/protocol/data/richstatus/RichStatus.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/network/protocol/data/richstatus/RichStatus.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/network/protocol/data/richstatus/RichStatus.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/network/protocol/data/richstatus/RichStatus.kt Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/utils/ImagePatcher.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/utils/ImagePatcher.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/utils/ImagePatcher.kt Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/utils/ImagePatcher.kt Outdated Show resolved Hide resolved
Him188
Him188 reviewed Nov 14, 2021
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests for ImagePatcher? It's essential to ensure Image works properly.

mirai-core/src/commonMain/kotlin/MiraiImpl.kt Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/message/MultiMsgUploader.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/utils/ImagePatcher.kt Show resolved Hide resolved
@Him188 Him188 added z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 and removed z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 labels Nov 15, 2021
Him188
Him188 requested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimize commit history and prepare for Rebase and Merge

@Karlatemp Karlatemp merged commit 42510d7 into dev Nov 16, 2021
@Karlatemp Karlatemp deleted the message/redesign branch November 16, 2021 04:38
@github-pages github-pages bot temporarily deployed to github-pages November 16, 2021 04:38 Inactive
@Karlatemp Karlatemp mentioned this pull request Nov 19, 2021
Closed
@Him188 Him188 changed the title Message redesign Redesign MultiMsg Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandtechnology sandtechnology sandtechnology left review comments

@Him188 Him188 Him188 requested changes

Assignees
No one assigned
Labels
N 优先级: 一般 t:enhancement 类型: 现有功能上的优化 t:feature 类型: 新特性 x:protocol 属性: 协议相关
Projects
None yet
Milestone
2.9.0-M1
3 participants
@Karlatemp @Him188 @sandtechnology