Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image.Factory and Image.Builder for constructing Image inst… #1673

Merged
merged 5 commits into from Nov 20, 2021

Conversation

Him188
Copy link
Member

@Him188 Him188 commented Nov 15, 2021

…ances with specific properties. close #1672

Requires #1671 (in docs only)

@Him188 Him188 added t:feature 类型: 新特性 M 优先级: 主要 labels Nov 15, 2021
@Him188 Him188 added this to the 2.9.0-M1 milestone Nov 15, 2021
@Him188
Copy link
Member Author

Him188 commented Nov 17, 2021

好像push错东西了, 等我check

@Him188 Him188 force-pushed the image-factory branch 2 times, most recently from d74a97d to dffa176 Compare November 19, 2021 01:28
@Him188 Him188 requested review from Karlatemp and removed request for Karlatemp November 19, 2021 01:38
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestUnit: Image.Builder.build() with properties changed

@Karlatemp Karlatemp added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Nov 20, 2021
@Him188 Him188 merged commit 7c550bf into dev Nov 20, 2021
@Him188 Him188 deleted the image-factory branch November 20, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M 优先级: 主要 t:feature 类型: 新特性 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持构造指定 size 等参数的 Image
2 participants