add: TemporalArgumentParser #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Him188
reviewed
Dec 18, 2021
mirai-console/backend/mirai-console/src/command/descriptor/CommandArgumentContext.kt
Show resolved
Hide resolved
Him188
approved these changes
Dec 18, 2021
mirai-console/backend/mirai-console/src/command/descriptor/CommandArgumentParserBuiltins.kt
Outdated
Show resolved
Hide resolved
|
For mamoe, after merge: Mark |
Karlatemp
approved these changes
Dec 24, 2021
Karlatemp
reviewed
Dec 24, 2021
mirai-console/backend/mirai-console/test/command/TestCommand.kt
Outdated
Show resolved
Hide resolved
Him188
reviewed
Jan 6, 2022
Comment on lines
483
to
488
| /** | ||
| * 解析参数为时间 [T] | ||
| * @param now 返回当前时间 | ||
| * @param parse 从字符串解析时间 | ||
| */ | ||
| public class TemporalArgumentParser<T : TemporalAccessor>( |
There was a problem hiding this comment.
由于设置不允许 maintainer 修改, 请标注 @MiraiExperimentalApi, 注释 @since 2.10, 准备合并
Him188
approved these changes
Jan 11, 2022
|
conflicts? |
Him188
approved these changes
Jan 12, 2022
strear
pushed a commit
to strear/mirai
that referenced
this pull request
Feb 21, 2022
* add: TemporalArgumentParser * fix: no reflect * fix: delete @Suppress("UNCHECKED_CAST") * fix: Temporal -> TemporalAccessor * add: test temporal argument * add: isInstance * docs: since 2.10 * docs: since 2.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加
TemporalArgumentParser类似EnumValueArgumentParser，自动完成
LocalDateOffsetDateTime等java.time.temporal.Temporal实现类 的 解析