Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AbstractConcurrentPermissionService #1843

Merged
merged 6 commits into from
Feb 22, 2022
Merged

Conversation

cssxsh
Copy link
Contributor

@cssxsh cssxsh commented Jan 21, 2022

No description provided.

@Karlatemp Karlatemp requested a review from Him188 January 21, 2022 07:30
@Karlatemp Karlatemp added N 优先级: 一般 s:console 子系统: mirai-console t:problem 类型: 不容易归类为特性或 bug 的综合问题 labels Jan 21, 2022
@Him188
Copy link
Member

Him188 commented Jan 30, 2022

待添加测试后再合并 (可能 console 原本就没有写 permission 的 tests)

@Him188 Him188 added the z:missing-tests 状态: 需要测试 label Jan 30, 2022
@Him188 Him188 added this to the Backlog milestone Jan 30, 2022
@cssxsh cssxsh requested a review from Him188 February 10, 2022 12:52
@Him188 Him188 added z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 and removed z:missing-tests 状态: 需要测试 labels Feb 21, 2022
@Him188 Him188 modified the milestones: Backlog, 2.11.0-RC Feb 21, 2022
@Him188 Him188 merged commit 5a1059b into mamoe:dev Feb 22, 2022
@Him188 Him188 modified the milestones: 2.11.0-RC, 2.11.0-M1 Mar 8, 2022
Him188 pushed a commit that referenced this pull request Mar 8, 2022
* fix: AbstractConcurrentPermissionService

* feat: cancel about

* fix: filter parent

* fix: return

* fix: filter parent

* add: PermissionServiceTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
N 优先级: 一般 s:console 子系统: mirai-console t:problem 类型: 不容易归类为特性或 bug 的综合问题 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants