try to fix #249 #500
Closed
try to fix #249 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请问是否有测试过? |
Closed
|
测试过了 |
Him188
requested changes
Aug 17, 2020
| @@ -78,7 +74,7 @@ internal class FriendImpl( | |||
| override val coroutineContext: CoroutineContext = coroutineContext + SupervisorJob(coroutineContext[Job]) | |||
|
|
|||
| @Suppress("unused") // bug | |||
| val lastMessageSequence: AtomicInt = atomic(-1) | |||
| val lastMessageSeqCacheList: AtomicResizeCacheList<Int> = AtomicResizeCacheList(15.minutesToMillis) | |||
There was a problem hiding this comment.
这个list只会增大不会变小, 15分钟保留时间过长, 请考虑 15 秒左右
There was a problem hiding this comment.
使用 AtomicResizeCacheList 无法解决问题
简单测试重复时间会长于1分钟
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.