Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for waste event start and endtime #679

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

sander1988
Copy link

@sander1988 sander1988 commented Feb 14, 2023

The MR adds (optional) support for waste event start and endtime.

My local regulations say that I'm allowed to put the waste out between 20:00 (the day before collection) and 18:00 (on collection day). This way the state of the waste calendar in HA is only 'on' when it's allowed.

In my case the configuration looks like this:

waste_collection_schedule:
  sources:
    - name: ximmio_nl
      args:
        company: xxxx
        post_code: xxxx
        house_number: 1
      customize:
        - type: PAPER
          alias: Papier
          start_hour: -4
          end_hour: 18
        - type: GREEN
          alias: GFT
          start_hour: -4
          end_hour: 18
        - type: PACKAGES
          alias: Plastic
          start_hour: -4
          end_hour: 18
        - type: RESIDUAL
          alias: Restafval
          start_hour: -4
          end_hour: 18

@sander1988 sander1988 changed the title Adds support for start and endtime for waste events Adds support for waste event start and endtime Feb 14, 2023
@5ila5
Copy link
Collaborator

5ila5 commented Oct 24, 2023

Please provide some documentation in doc/installation.md

@mampfes what do you think about this?

@mampfes
Copy link
Owner

mampfes commented Oct 25, 2023

Sorry, I wouldn't merge this PR. I'm afraid that this hasn't been fully thought through. And I think there are other ways to do, for example, automations for all-day events in the calendar.

@sander1988
Copy link
Author

Please provide some documentation in doc/installation.md

Yes, but let me know if you want to merge it or not before I put in the effort.

@sander1988
Copy link
Author

Sorry, I wouldn't merge this PR. I'm afraid that this hasn't been fully thought through. And I think there are other ways to do, for example, automations for all-day events in the calendar.

The reason to implement it in the plugin instead of the automation/calendar is simple... Here it has to be implemented in one single place. Otherwise it has to be implemented several times for every component and automation using this feature with multiple locations of the same configuration (like hour offsets).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants