Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

Commit

Permalink
Various fixes added to PR
Browse files Browse the repository at this point in the history
(fix) handle ImageWidget without linkedPage
(fix) set openHAB2 as default server
(fix) moved selection list and color picker to left (PR49e3d14)
(fix) altered colors (PR49e3d14)
  • Loading branch information
mampfes committed Jun 11, 2017
1 parent 06563ad commit aaa5c39
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 11 deletions.
6 changes: 6 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
V2.0.1 (11-Jun-2017)
(fix) handle ImageWidget without linkedPage
(fix) set openHAB2 as default server
(fix) moved selection list and color picker to left (PR49e3d14)
(fix) altered colors (PR49e3d14)

V2.0.0 (10-Mar-2017)
(fix) fixed krypton support
(add) openhab2 support
Expand Down
20 changes: 11 additions & 9 deletions default.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,17 @@ def build_menu(self):

try:
self.oh.load_sitemaps()
self.homepage = self.oh.sitemaps[ADDON.getSetting('sitemap')].load_page()
try:
sitemap = self.oh.sitemaps[ADDON.getSetting('sitemap')]
except KeyError:
# invalid sitemap -> close window immediately
debugPrint(1, "build_menu failed, host=%s, port=%s, auth=%s, sitemap=%s sitemaps=%s" %
(ADDON.getSetting('host'), ADDON.getSetting('port'),
ADDON.getSetting('authentication'), ADDON.getSetting('sitemap'), self.oh.sitemaps))
xbmcgui.Dialog().ok(ADDON.getLocalizedString(30007), ADDON.getLocalizedString(30206))
self.close()
ADDON.openSettings()
self.homepage = sitemap.load_page()
except requests.exceptions.RequestException as e:
# no connection to openhab server -> close window immediately
debugPrint(1, "build_menu failed, host=%s, port=%s, auth=%s, e=%s" %
Expand All @@ -57,14 +67,6 @@ def build_menu(self):
xbmcgui.Dialog().ok(ADDON.getLocalizedString(30007), ADDON.getLocalizedString(30201))
self.close()
ADDON.openSettings()
except KeyError:
# invalid sitemap -> close window immediately
debugPrint(1, "build_menu failed, host=%s, port=%s, auth=%s, sitemap=%s" %
(ADDON.getSetting('host'), ADDON.getSetting('port'),
ADDON.getSetting('authentication'), ADDON.getSetting('sitemap')))
xbmcgui.Dialog().ok(ADDON.getLocalizedString(30007), ADDON.getLocalizedString(30206))
self.close()
ADDON.openSettings()
self.enter_sub_menu(self.homepage)

def enter_sub_menu(self, page):
Expand Down
5 changes: 4 additions & 1 deletion resources/lib/openhab2.py
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,10 @@ def __init__(self, page, widgetData):
@update_proxy
def init(self, widgetData):
super(ImageWidget, self).init(widgetData)
self.attribs['linkedPage'] = widgetData['linkedPage'] # don't create an extra Page because not used so far
if 'linkedPage' in widgetData:
self.attribs['linkedPage'] = widgetData['linkedPage'] # don't create an extra Page because not used so far
else:
self.attribs['linkedPage'] = None
self.attribs['url'] = widgetData['url']
self.attribs['refresh'] = int(widgetData.get('refresh', 0))

Expand Down
2 changes: 1 addition & 1 deletion resources/settings.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<settings>
<setting label="30012" id="server" type="enum" lvalues="30120|30121" default="0"/>
<setting label="30012" id="server" type="enum" lvalues="30120|30121" default="1"/>
<setting label="30000" id="host" type="text" default="127.0.0.1"/>
<setting label="30001" id="port" type="number" default="8080"/>
<setting label="30006" type="action" action="RunScript(script.module.openhab, show_sitemaps)"/>
Expand Down

0 comments on commit aaa5c39

Please sign in to comment.