Code review

man-group · Jun 25, 2024 · 8e7a57a · 8e7a57a
1 parent 0610bf8
commit 8e7a57a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cpp/arcticdb/stream/stream_utils.hpp b/cpp/arcticdb/stream/stream_utils.hpp
@@ -368,7 +368,7 @@ inline std::set<StreamId> filter_by_regex(const std::set<StreamId>& results, con
     return filtered_results;
 }
 
-inline std::vector<std::string_view> get_index_columns_from_descriptor(const TimeseriesDescriptor& tsd) {
+inline std::vector<std::string> get_index_columns_from_descriptor(const TimeseriesDescriptor& tsd) {
     const auto& norm_info = tsd.proto().normalization();
     const auto& stream_descriptor = tsd.as_stream_descriptor();
     // For explicit integer indexes, the index is actually present in the first column even though the field_count
@@ -380,9 +380,9 @@ inline std::vector<std::string_view> get_index_columns_from_descriptor(const Tim
     else
         index_till = 1 + common.multi_index().field_count();  //# The value of field_count is len(index) - 1
 
-    std::vector<std::string_view> index_columns;
+    std::vector<std::string> index_columns;
     for(auto field_idx = 0; field_idx < index_till; ++field_idx)
-        index_columns.push_back(stream_descriptor.fields(field_idx).name());
+        index_columns.push_back(std::string{stream_descriptor.fields(field_idx).name()});
 
     return index_columns;
 }