Inline missing group id constant

Fix compilation on Windows, see: https://github.com/man-group/ArcticDB/actions/runs/9362879091/job/25772502891?pr=1574 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
man-group · Jun 4, 2024 · e2e9d39 · e2e9d39
1 parent 665a9a1
commit e2e9d39
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cpp/arcticdb/processing/clause.cpp b/cpp/arcticdb/processing/clause.cpp
@@ -387,7 +387,6 @@ Composite<EntityIds> AggregationClause::process(Composite<EntityIds>&& entity_id
                         ++next_group_id;
                     }
                     ssize_t previous_value_index = 0;
-                    constexpr size_t missing_value_group_id = 0;
 
                     Column::for_each_enumerated<typename col_type_info::TDT>(
                             *col.column_,
@@ -421,7 +420,8 @@ Composite<EntityIds> AggregationClause::process(Composite<EntityIds>&& entity_id
                                 if (is_sparse) {
                                     for (auto j = previous_value_index;
                                          j != enumerating_it.idx(); ++j) {
-                                        *row_to_group_ptr++ = missing_value_group_id;
+                                        // We use 0 for the missing value group id
+                                        *row_to_group_ptr++ = 0;
                                     }
                                     previous_value_index = enumerating_it.idx() + 1;
                                 }
@@ -913,7 +913,7 @@ void merge_impl(
         input_streams, agg, add_symbol_column);
 }
 
-// MergeClause receives a list of DataFrames as input and merge them into a single one where all 
+// MergeClause receives a list of DataFrames as input and merge them into a single one where all
 // the rows are sorted by time stamp
 Composite<EntityIds> MergeClause::process(Composite<EntityIds>&& entity_ids) const {
     auto procs = gather_entities(component_manager_, std::move(entity_ids));