Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate C++20 features #1608

Closed
alexowens90 opened this issue Jun 10, 2024 · 0 comments · Fixed by #1614
Closed

Reinstate C++20 features #1608

alexowens90 opened this issue Jun 10, 2024 · 0 comments · Fixed by #1614
Assignees
@alexowens90
Labels
refactor

Comments

@alexowens90
Copy link
Collaborator

alexowens90 commented Jun 10, 2024 •
edited
Loading

C++20 support was backed out in #1542 due to a crash observed with the following snippet:

import arcticdb
import ray

Support was re-added in #1572 with this crash fixed. The task is to reinstate C++20 features backed out in:
@alexowens90 alexowens90 self-assigned this Jun 10, 2024
@alexowens90 alexowens90 mentioned this issue Jun 10, 2024
Merged
alexowens90 added a commit that referenced this issue Jun 11, 2024
@alexowens90
Refactor 1608: Re-introduce C++20 features (#1614)
16070dc 
#### Reference Issues/PRs
Closes #1608 

Pure refactor to reintroduce some C++20 features (mostly `concepts`,
`std::ranges::reverse_view`, and `std::erase_if`) that were removed when
we emergency reverted to C++17 due to the `ray` import issue.

There are more comments in the code base referencing changes that can be
made after moving to C++20, particularly in `ranges_from_future.hpp`,
but these require more intrusive changes throughout the code base.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexowens90 alexowens90

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor 1608: Re-introduce C++20 features man-group/ArcticDB
1 participant
@alexowens90