Centralise the pytest marks #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaced the manual fixture parameterization in test_deletion.py
poodlewars
approved these changes
Nov 1, 2023
| "lmdb_version_store_v1", | ||
| "lmdb_version_store_v2", | ||
| "s3_version_store_v1", | ||
| "s3_version_store_v2", |
There was a problem hiding this comment.
Unrelated to this PR, but I think we should drop the s3_version_store_v2 fixture from these lists. Doing one encoding on S3, and both on LMDB (which is much faster) ought to be fine
There was a problem hiding this comment.
I can mark it with a thorough custom mark, which will make it easy to skip from the command line at a later date.
|
|
||
| # These two should become pytest marks as opposed to variables feeding into skipif | ||
| PERSISTENT_STORAGE_TESTS_ENABLED = os.getenv("ARCTICDB_PERSISTENT_STORAGE_TESTS") == "1" | ||
| FAST_TESTS_ONLY = os.getenv("ARCTICDB_FAST_TESTS_ONLY") == "1" |
There was a problem hiding this comment.
Thanks for keeping FAST_TESTS_ONLY alive, I added it recently just for local development, otherwise the feedback cycle is horrific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Forked out of #1014
What does this implement or fix?
Move the various
skipifto a centralised location to improve maintainability.Checklist
Checklist for code changes...