Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs workflow fixes. #1030

Merged
merged 5 commits into from
Nov 4, 2023
Merged

Docs workflow fixes. #1030

merged 5 commits into from
Nov 4, 2023

Conversation

jamesmunro
Copy link
Collaborator

Add write permission, use tag name (v prefix) and require environment.

@jamesmunro
Copy link
Collaborator Author

@jamesmunro
Copy link
Collaborator Author

With the fixes here I've managed to build the branch and preview in cloudflare using two versions, 4.1 and master.

https://d4199475.arcticdb-docs.pages.dev/

@poodlewars
Copy link
Collaborator

With the fixes here I've managed to build the branch and preview in cloudflare using two versions, 4.1 and master.

https://d4199475.arcticdb-docs.pages.dev/

Why can't I see the versions dropdown on this deployment?

@jamesmunro
Copy link
Collaborator Author

jamesmunro commented Nov 3, 2023

With the fixes here I've managed to build the branch and preview in cloudflare using two versions, 4.1 and master.
https://d4199475.arcticdb-docs.pages.dev/

Why can't I see the versions dropdown on this deployment?

Not totally sure. Maybe because there are not two stable versions.

If you go to dev you can see it: https://d4199475.arcticdb-docs.pages.dev/dev/

@jamesmunro
Copy link
Collaborator Author

jamesmunro commented Nov 4, 2023

@poodlewars

Why can't I see the versions dropdown on this deployment?

Okay. Figured it out. It's because 4.1.0 builds with the 4.1.0 mkdocs.yml into the 4.1.0 subdir.
4.1.0 didn't have versioning, so I need backport versioning it for it to appear.

@jamesmunro jamesmunro merged commit f47b7cd into master Nov 4, 2023
101 checks passed
@jamesmunro jamesmunro deleted the docs-versioning-fixes branch November 4, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants