Bugfix 1182: Unskip test that is no longer flaky #1197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1182
Git archaeology suggests this test has not been flaky for a while, and that it was mistakenly skipped, Evidence:
test_read_ts
, which also had an old implementation using sleeps instead of thedistinct_timestamps
context manager now in use in both tests onmaster
distinct_timestamps
context manager was added totest_find_version
in a PR on 10/8/23, and the test was not marked as skipped at this point.xfail
mark was added in a commit titled "Reapply parts of the previous commit that isn't superseded without formatting to avoid conflicts", merged as part of this PR.xfail
, suggesting only the changes totest_file_config.py
were intentional.For additional safety, I ran the test 1000 times in all supported configurations in the CI, with no failures.