Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1182: Unskip test that is no longer flaky #1197

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

alexowens90
Copy link
Collaborator

Closes #1182

Git archaeology suggests this test has not been flaky for a while, and that it was mistakenly skipped, Evidence:

  • Original bullet point in flaky tests epic linked to (now expired) logs from a build on 14/7/23, which had an old implementation of this test, and said that the failure looked similar to test_read_ts, which also had an old implementation using sleeps instead of the distinct_timestamps context manager now in use in both tests on master
  • The distinct_timestamps context manager was added to test_find_version in a PR on 10/8/23, and the test was not marked as skipped at this point.
  • The xfail mark was added in a commit titled "Reapply parts of the previous commit that isn't superseded without formatting to avoid conflicts", merged as part of this PR.
  • However, none of the other commits in this PR removed the xfail, suggesting only the changes to test_file_config.py were intentional.

For additional safety, I ran the test 1000 times in all supported configurations in the CI, with no failures.

@jamesmunro jamesmunro self-requested a review January 3, 2024 15:04
@alexowens90 alexowens90 merged commit 97eeb41 into master Jan 4, 2024
129 of 130 checks passed
@alexowens90 alexowens90 deleted the bugfix/1182/unskip-test_find_version branch January 4, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: Windows 3.8 test_find_version
2 participants