hot-fix: Use cmake 3.29.2 with jwlawson/actions-setup-cmake@v2
#1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
changed the title
jwlawson/actions-setup-cmake@v2
See: actions/runner-images#9680 (comment) Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Muhammad Hamza Sajjad <muhammadhamzasajjad@gmail.com>
poodlewars
approved these changes
Apr 13, 2024
| @@ -73,6 +73,13 @@ jobs: | |||
| with: | |||
| submodules: recursive # Just in case a dep has its own third-party deps | |||
|
|
|||
| # See: https://github.com/actions/runner-images/issues/9680#issuecomment-2051917949 | |||
| - name: HOTFIX Setup CMake 3.29.2 | |||
There was a problem hiding this comment.
We don't really need to say HOTFIX do we? Choosing our own CMake seems sensible and not a hack.
Why are we only doing this on Windows? Using the CMake across all platforms might help to simplify the CI setup a bit.
There was a problem hiding this comment.
The next image should come with this newer version of CMake, and I think this pin should rather be temporary as it duplicates installations of CMake.
I pinned for Windows because it was the only OS affected by the update of the image.
Nevertheless, the name of this step definitely can be changed.
Feel free to author changes on top of mine if you want to.
There was a problem hiding this comment.
What do you think?
Suggested change
| - name: HOTFIX Setup CMake 3.29.2 | |
| - name: Setup CMake 3.29.2 |
muhammadhamzasajjad
added a commit
that referenced
this pull request
Apr 15, 2024
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Muhammad Hamza Sajjad <muhammadhamzasajjad@gmail.com>
jjerphan
added a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See: actions/runner-images#9680 (comment)
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...