Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only write ref key once when writing with prune_previous_versions #1560

Merged
merged 4 commits into from
May 15, 2024

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    e5be2f3 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Terminate the child processes so that pytest can terminate, otherwise…

    … pytest continues to run indefinitely even after the tests have passed.
    poodlewars committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6ca50a0 View commit details
    Browse the repository at this point in the history
  2. Fix places where write_entry_to_storage and its callers both write th…

    …e symbol ref key.
    
    Usage:
    
    write_entry_to_storage
    |_ compact_and_remove_deleted_indexes (unused, no impact)
      |_ writes the symbol ref a second time
    |_ overwrite_symbol_tree
      |_ writes the symbol ref a second time
    |_ rewrite_entry
      |_ recover_deleted
        |_ writes the symbol ref a second time
      |_ remove_and_rewrite_version_keys
        |_ writes the symbol ref a second time
      |_ scan_and_rewrite
        |_ writes the symbol ref a second time
    
    overwrite_symbol_tree is used in:
    
        initial sync process in replication (no impact really, we don't expect stuff to be readable during the initial sync)
        fix_symbol_trees (unused)
    
    recover_deleted is only used in tests
    
    remove_and_rewrite_version_keys is unused
    
    scan_and_rewrite is used in fix_ref_key which is unused
    
    Testing limited as most call sites are unused. I verified that replication still works correctly after this change.
    poodlewars committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5d863eb View commit details
    Browse the repository at this point in the history
  3. Make sure that we always terminate the child processes so that we don…

    …'t hang the CI suite for 6 hours...
    poodlewars committed May 15, 2024
    Configuration menu
    Copy the full SHA
    88d534e View commit details
    Browse the repository at this point in the history