Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Update to boost 1.84.0 #1574

Merged
merged 17 commits into from
Jun 5, 2024
Merged

maint: Update to boost 1.84.0 #1574

merged 17 commits into from
Jun 5, 2024

Conversation

jjerphan
Copy link
Collaborator

@jjerphan jjerphan commented May 17, 2024

Reference Issues/PRs

To be merged after #1572.

Towards #1412 (replacing folly/concurrency/ConcurrentHashMap with boost::unordered::concurrent_flat_map)

Towards #818.

What does this implement or fix?

Update boost to 1.84.0 which is the version which will be used on conda-forge.

See conda-forge's migration for boost 1.84.0

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

jjerphan and others added 12 commits May 15, 2024 16:03
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
We need it for replacing `folly/concurrency/ConcurrentHashMap`
with `boost::unordered::concurrent_flat_map` which only
was introduced in 1.84.

Also The conda-forge migration for 1.84 is almost done:
https://conda-forge.org/status/migration/boost1840

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan changed the title maint: update to boost 1.84.0 maint: Update to boost 1.84.0 May 17, 2024
@jjerphan jjerphan marked this pull request as ready for review May 17, 2024 16:44
@jjerphan jjerphan force-pushed the maint/update-to-boost-1.84.0 branch from bfb0019 to c70edea Compare May 17, 2024 16:46
@vasil-pashov
Copy link
Collaborator

AFAIK Boost has released 1.85.0 is there any reason to prefer 1.84.0 over that?

@jjerphan
Copy link
Collaborator Author

Boost 1.84.0 is the version which will be used by conda-forge entirely.

See conda-forge's migration for boost 1.84.0.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the maint/update-to-boost-1.84.0 branch 2 times, most recently from fbb379a to 7fb9730 Compare May 22, 2024 10:42
@jjerphan jjerphan merged commit 66830f7 into master Jun 5, 2024
114 checks passed
@jjerphan jjerphan deleted the maint/update-to-boost-1.84.0 branch June 5, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants