maint: Update to boost 1.84.0 #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
We need it for replacing `folly/concurrency/ConcurrentHashMap` with `boost::unordered::concurrent_flat_map` which only was introduced in 1.84. Also The conda-forge migration for 1.84 is almost done: https://conda-forge.org/status/migration/boost1840 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
jjerphan
force-pushed
the
maint/update-to-boost-1.84.0
branch
from
bfb0019
to
c70edea
Compare
5 tasks
|
AFAIK Boost has released |
|
Boost 1.84.0 is the version which will be used by conda-forge entirely. |
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
maint/update-to-boost-1.84.0
branch
2 times, most recently
from
fbb379a
to
7fb9730
Compare
Fix compilation on Windows, see: https://github.com/man-group/ArcticDB/actions/runs/9362879091/job/25772502891?pr=1574 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
This reverts commit 14ef5ed.
willdealtry
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
To be merged after #1572.
Towards #1412 (replacing
folly/concurrency/ConcurrentHashMapwithboost::unordered::concurrent_flat_map)Towards #818.
What does this implement or fix?
Update boost to 1.84.0 which is the version which will be used on conda-forge.
See conda-forge's migration for boost 1.84.0
Any other comments?
Checklist
Checklist for code changes...