Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'python setup.py install' leaves out several subpackages #7

Closed
bjorskog opened this issue Jun 15, 2015 · 2 comments
Closed

'python setup.py install' leaves out several subpackages #7

bjorskog opened this issue Jun 15, 2015 · 2 comments
Milestone

Comments

@bjorskog
Copy link

Hi.

Running the current version of setup.py will leave out several of the subpackages, e.g. arctic.store and arctic.tickstore.

Instead of using "packages=['arctic', 'tests']" in setup.py, would it not be better to use "packages=find_packages()"? After applying this change it installs nicely.

I'm on OSX so I don't have a pull that fixes this due to clang and OpenMP lacking compatibility leading to other changes, and thus lots of failing unittests.

@jamesblackburn
Copy link
Contributor

Ok, thanks for the heads up. I'll take a look.

Re the OS X issue, OpenMP is only used for parallel lz4 compression (which isn't strictly needed, but useful for large frames). I filed a bug against home-brew on this not clear whether there's something wrong with my setup or an issue with the brew recipe:
Homebrew/legacy-homebrew#40391

@bjorskog
Copy link
Author

Ok, I'll take a look at OpenMP. My quick goocle search only indicated problems, so I didn't try all that hard..

Nice package though, thanks!

jamesblackburn added a commit that referenced this issue Jul 14, 2015
Install all sub-packages recursively - fixes #7
@jamesblackburn jamesblackburn modified the milestone: v1.0.0 Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants