Add import indent #74
Conversation
|
Thanks! Will need a unit test too which exercises the broken code |
femtotrader
force-pushed
the
fix49_str_tick_lib
branch
4 times, most recently
from
7ca11dc
to
776f656
Compare
|
It should be ok... Please tell me is something is missing |
|
You need to add a unit test for the broken code. The test should fail without your fix and pass with it. |
|
This is the case see |
| # Fix GH issue 49 - str(tick library) fails in IPython | ||
| store = Arctic(mongo_host=mongo_host) | ||
| store.initialize_library('library_name', 'TickStoreV3') | ||
| s = str(store['library_name']) |
There was a problem hiding this comment.
assert 'arctic.library_name' in str(store['library_name']) would be nicer
|
LGTM |
femtotrader
force-pushed
the
fix49_str_tick_lib
branch
from
a9065fe
to
7a158be
Compare
added and commits squashed |
| @@ -144,3 +144,9 @@ def test_default_mongo_retry_timout(): | |||
| with pytest.raises(LibraryNotFoundException): | |||
| Arctic('unresolved-host', serverSelectionTimeoutMS=0)['some.lib'] | |||
| assert time.time() - now < 1. | |||
|
|
|||
| def test_stringify_tickstore_library(mongo_host): | |||
There was a problem hiding this comment.
This test should really live on a test file with the sae name as the module under test. test_tickstore.py or similar...
There was a problem hiding this comment.
sorry @jamesblackburn ... @AdrianTeng merged it ... do you want I move this test or will you do it ?
There was a problem hiding this comment.
Could you make it a unit test, too :)
Try to fix #49