Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape curly brackets for correlations chart #670

Closed
wants to merge 2 commits into from

Conversation

lironle6
Copy link

Hey,
First pull request so please let me know if I'm doing anything wrong.
Stumbled into an issue which I opened here:
#669
And wanted to contribute my fix to it. It's a more "quick and dirty" solution as I don't know if any other modules are affected by the same issues (I manually tested most and couldn't find any).
The fix itself is pretty straightforward, and if any modules need an escape in the future there's a new parameter to toggle.
Appreciate any and all input regarding the issue/pull.
Thanks!

@aschonfeld
Copy link
Collaborator

@shnitzel6 Thanks so much for the PR! I've actually found the issue and am working on merging a branch that fixes it. I appreciate the effort you put in making this PR but there's just too many instances where I could see curly braces being used in a code export where you wouldn't want them escaped. Take your replacement for example:

s = df['Sex']
s = s.replace({'male': '0', 'female': '1'})
df.loc[:, 'Sex'] = s

Thanks again, this really helped me diagnose the issue quickly

@aschonfeld aschonfeld closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants