Implement Ipc Client #8

ayrat555 · 2017-10-03T20:47:51Z

Implement Ipc Client like HttpClient is implemented (with Ethereumex.Client.Macro)

defmodule Ethereumex.IpcClient do
  use Ethereumex.Client.Macro

  def request(payload) do
    // request with Unix socket
  end
end

Currently there is no decent adapter for Unix sockets in Elixir ecosystem. I think we should try to use procket but its api is too ugly and low level.

After finishing ipcClient HttpClient in SmartContract modules should be replaced with the new client.

The text was updated successfully, but these errors were encountered:

NickPapacostas · 2017-12-01T11:53:36Z

@ayrat555 I'm interested in working on this, were you thinking of using something like procket to communicate with the socket?

thanks for all your work!

ayrat555 · 2017-12-12T09:44:06Z

@NickPapacostas I'm sorry for a late answer. Yes, I thought about using procket. But as I wrote earlier its interface is very ugly.
I'll try to dig into it in my spare time. Btw PRs are welcome

plu9in · 2018-02-17T12:05:29Z

@ayrat555 @NickPapacostas
Is it not possible to use https://stackoverflow.com/questions/1478831/erlang-unix-domain-socket-support ?

ayrat555 · 2018-02-17T13:42:32Z

@plu9in Yes, it's possible.

@NickPapacostas wanted to work on this

gitcoinbot · 2018-06-18T16:54:44Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.4 ETH (199.06 USD @ $497.65/ETH) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$24,798.60 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot · 2018-06-22T16:15:39Z

@raininja Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

spm32 · 2018-06-25T01:54:54Z

Hi @NickPapacostas, did you still want to work on this?

raininja · 2018-06-25T05:57:55Z

I'm working on it. I will be happy to let it go if there was someone else more interested, or has started work on it.

raininja · 2018-06-27T20:04:43Z

I've decided to implement shackle for the IPC Client. I am wondering if it would not be prudent to also upgrade(?) the httpclient at the same time? Or is this approach too heavy? @ayrat555

ayrat555 · 2018-06-27T20:10:27Z

why httpclient should be upgraded?
does shackle support unix sockets?

raininja · 2018-06-27T23:10:21Z

@ayrat555 I was thinking that httpclient would need to be upgraded to sync the two "backends"
and yes, shackle does support unix sockets
If you check jsonrpc-elixir as a reference, they've used shackle and buoy to this effect.

If you think this approach is to heavy/invasive, I can simply use gen_rpc for this

ayrat555 · 2018-06-28T07:55:56Z

Let's use gen_rpc. Thanks

gitcoinbot · 2018-07-01T16:15:22Z

@raininja Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2018-07-04T16:15:24Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@raininja due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

vs77bb · 2018-07-06T06:39:09Z

Hi @raininja are you still working on this one? Hope you are doing well 🙂

raininja · 2018-07-07T02:38:08Z

@vs77bb yes I am! All the best!

raininja · 2018-07-08T16:45:54Z

Why have I gotten an email saying I was removed from this bounty?

spm32 · 2018-07-08T17:58:18Z

Sorry @raininja that's just an automated message from gitcoinbot, you're still on the issue, snoozing the bot now.

mkosowsk · 2018-07-18T20:51:05Z

@raininja how's your cornea? :) Think you'll be able to take a look at this issue? Thanks!

raininja · 2018-07-18T21:35:54Z

@mkosowsk I'm ok, thanks. I'm actually working on this now, having a bit of an issue as the documentation for the go-ethereum client days one thing but the geth console says another, the APIs don't seem to match

raininja · 2018-07-19T01:31:59Z

@mkosowsk I'm ok, thanks. I'm actually working on this now, having a bit of an issue as the documentation for the go-ethereum client days one thing but the geth console says another, the APIs don't seem to match

mkosowsk · 2018-07-19T11:40:41Z

@ayrat555 do you have any insight on @raininja's issue on why the API's don't seem to match? Thanks!

ayrat555 · 2018-07-19T11:48:18Z

Maybe geth's API includes custom methods or methods in the library is out of date

gitcoinbot · 2018-07-28T16:15:06Z

@raininja Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2018-07-31T16:15:08Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@raininja due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

raininja · 2018-08-01T03:03:45Z

Still working on this, recently submitted a WIP PR

raininja · 2018-08-09T04:53:01Z

still plugging away, awaiting some feedback from @ayrat555

raininja · 2018-09-07T14:45:01Z

no response in over a month from @ayrat555
not sure how to proceed on this?

ayrat555 · 2018-09-07T15:36:37Z

@raininja I don't see any notable progress there. A lot of commented code, changes in README and json cassette file changes.

raininja · 2018-09-07T15:53:00Z

OK, so at least I can see that you've looked at the code. That which is commented out is not implemented, as far as I can tell. I've checked with geth, ganache, and parity. . .

hswick · 2018-10-06T16:41:01Z

Hi @ceresstation I would like to register for this bounty. See #40, but according to gitcoin it doesnt seem like I can right now.

ayrat555 · 2018-10-06T17:00:02Z

@raininja can you please unassign yourself from this issue on gitcoin? @hswick has done a pretty good job and his PR will be merged soon

raininja · 2018-10-06T20:22:21Z

OK

…

On Sat, Oct 6, 2018, 1:00 PM Ayrat Badykov ***@***.***> wrote: @raininja <https://github.com/raininja> can you please unassign yourself from this issue on gitcoin? @hswick <https://github.com/hswick> has done a pretty good job and his PR will be merged soon — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-iT-TPkF2UOKb-jqPdq6cqfJwT1uCFks5uiOGHgaJpZM4Psv5Q> .

ayrat555 · 2018-10-07T15:28:32Z

@hswick you should try to assign yourself to the issue on gitcoin

gitcoinbot · 2018-10-07T15:50:29Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 3 months, 1 week from now.
Please review their action plans below:

1) hswick has started work.

Finish up Pull Request-
Documentation
Handle config more gracefully
Include Parity binary

Learn more on the Gitcoin Issue Details page.

gitcoinbot · 2018-10-07T19:17:35Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.4 ETH (89.85 USD @ $224.62/ETH) has been submitted by:

@hswick

@ceresstation please take a look at the submitted work:

(Link Not Provided) by @hswick

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$36,517.60 more funded OSS Work available on the Gitcoin Issue Explorer

ayrat555 · 2018-10-23T07:28:06Z

@ceresstation ping

hswick · 2018-11-02T21:19:19Z

@ceresstation pong

gitcoinbot · 2018-11-12T20:25:30Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.4 ETH (84.82 USD @ $212.04/ETH) attached to this issue has been approved & issued to @hswick.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$47,598.94 more funded OSS Work available on the Gitcoin Issue Explorer

spm32 · 2018-11-12T20:27:02Z

Sorry about that @hswick, lost track of this in the conference rush, just paid you out!

hswick · 2018-11-12T21:17:39Z

Thanks @ceresstation appreciate it!

ayrat555 mentioned this issue Oct 4, 2017

Roadmap schedule / feature completion list #9

Closed

ayrat555 added the help wanted label Oct 12, 2017

hswick mentioned this issue May 8, 2018

Generic Client Protocol #23

Closed

hswick mentioned this issue Oct 4, 2018

IpcClient Implementation #40

Merged

hswick closed this as completed Nov 12, 2018

Implement Ipc Client #8

Implement Ipc Client #8

Comments

ayrat555 commented Oct 3, 2017 • edited Loading

NickPapacostas commented Dec 1, 2017

ayrat555 commented Dec 12, 2017 • edited Loading

plu9in commented Feb 17, 2018 • edited Loading

ayrat555 commented Feb 17, 2018

gitcoinbot commented Jun 18, 2018

gitcoinbot commented Jun 22, 2018

spm32 commented Jun 25, 2018

raininja commented Jun 25, 2018

raininja commented Jun 27, 2018 • edited Loading

ayrat555 commented Jun 27, 2018

raininja commented Jun 27, 2018 • edited Loading

ayrat555 commented Jun 28, 2018

gitcoinbot commented Jul 1, 2018

gitcoinbot commented Jul 4, 2018

vs77bb commented Jul 6, 2018 • edited Loading

raininja commented Jul 7, 2018 • edited Loading

raininja commented Jul 8, 2018

spm32 commented Jul 8, 2018 • edited Loading

mkosowsk commented Jul 18, 2018

raininja commented Jul 18, 2018

raininja commented Jul 19, 2018

mkosowsk commented Jul 19, 2018

ayrat555 commented Jul 19, 2018

gitcoinbot commented Jul 28, 2018

gitcoinbot commented Jul 31, 2018

raininja commented Aug 1, 2018

raininja commented Aug 9, 2018

raininja commented Sep 7, 2018

ayrat555 commented Sep 7, 2018

raininja commented Sep 7, 2018 • edited Loading

hswick commented Oct 6, 2018

ayrat555 commented Oct 6, 2018

raininja commented Oct 6, 2018 via email

ayrat555 commented Oct 7, 2018

gitcoinbot commented Oct 7, 2018 • edited Loading

gitcoinbot commented Oct 7, 2018

ayrat555 commented Oct 23, 2018

hswick commented Nov 2, 2018

gitcoinbot commented Nov 12, 2018

spm32 commented Nov 12, 2018

hswick commented Nov 12, 2018

ayrat555 commented Oct 3, 2017 •

edited

Loading

ayrat555 commented Dec 12, 2017 •

edited

Loading

plu9in commented Feb 17, 2018 •

edited

Loading

raininja commented Jun 27, 2018 •

edited

Loading

raininja commented Jun 27, 2018 •

edited

Loading

vs77bb commented Jul 6, 2018 •

edited

Loading

raininja commented Jul 7, 2018 •

edited

Loading

spm32 commented Jul 8, 2018 •

edited

Loading

raininja commented Sep 7, 2018 •

edited

Loading

gitcoinbot commented Oct 7, 2018 •

edited

Loading