Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stTransactionTest group #159

Closed
vyorkin opened this issue Jun 11, 2018 · 0 comments
Closed

Fix stTransactionTest group #159

vyorkin opened this issue Jun 11, 2018 · 0 comments

Comments

@vyorkin
Copy link
Contributor

vyorkin commented Jun 11, 2018

Regarding EmptyTransaction, EmptyTransaction2, EmptyTransaction3, the result of executing the EmptyTransaction should behave differently depending on if the EIP158.

  1. < EIP158 - creates an empty account https://github.com/ethereum/tests/blob/develop/src/GeneralStateTestsFiller/stTransactionTest/EmptyTransactionFiller.json#L24
  2. >= EIP158 - doesn't create an empty account https://github.com/ethereum/tests/blob/develop/src/GeneralStateTestsFiller/stTransactionTest/EmptyTransactionFiller.json#L42

I don't understand how its suppose to create an empty account because this transaction doesn't pass the validation as per Eq.(58) of the YP (g_0 <= T_g).

So for our empty transaction we have:

g_0 = 21000 (because it's the cost of G_transaction paid for every tx)
T_g = 0

So I guess we shouldn't execute this transaction at all (that's how it currently works after I've added transaction validation). But how not executing transaction results in a newly created account?

If I understand correctly the problem is that if we're testing against the Frontier chain then the correct behavior (not executing such transaction) is considered incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants