Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Port cargo, ripgrep and exa #102

Merged
merged 4 commits into from May 30, 2021
Merged

rust: Port cargo, ripgrep and exa #102

merged 4 commits into from May 30, 2021

Conversation

64
Copy link
Member

@64 64 commented May 8, 2021

This PR implements support for cargo builds. We also port ripgrep and exa, implementing the necessary patches for them to build.

In order to test this PR, you must have managarm/xbstrap#48 merged locally, and then run xbstrap init ../src from your build directory.

@64 64 mentioned this pull request May 8, 2021
@64 64 added this to In progress in Rust May 8, 2021
@64 64 changed the title rust: Port cargo and ripgrep rust: Port cargo, ripgrep and exa May 10, 2021
@64
Copy link
Member Author

64 commented May 10, 2021

ATM we're running into an issue when running cargo update repeatedly: rust-lang/cargo#9470.

I also don't like the fact that we need to hardcode all the lib versions in our ports (see the configure step of ripgrep and exa). I'll keep searching for a better solution.

@64 64 force-pushed the cargo branch 3 times, most recently from 4f676e2 to fea953b Compare May 11, 2021 00:33
@64
Copy link
Member Author

64 commented May 28, 2021

This is ready now, but it requires an xbstrap release

@64 64 marked this pull request as ready for review May 28, 2021 13:05
@avdgrinten
Copy link
Member

LGTM. Thank you for the PR!

@avdgrinten avdgrinten merged commit 667f0ba into managarm:master May 30, 2021
Rust automation moved this from In progress to Done May 30, 2021
Copy link

@tungmeoo tungmeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@64 64 deleted the cargo branch August 8, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Rust
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants