Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing opcode: Implement BreakPoint() and Fatal() #37

Closed
avdgrinten opened this issue Jul 24, 2019 · 8 comments
Closed

Missing opcode: Implement BreakPoint() and Fatal() #37

avdgrinten opened this issue Jul 24, 2019 · 8 comments
Assignees

Comments

@avdgrinten
Copy link
Member

Add the missing opcode and a unit test.

@thomtl thomtl self-assigned this Jul 26, 2019
@thomtl
Copy link
Member

thomtl commented Jul 26, 2019

How should we handle a breakpoint?
I was thinking of creating a laihost_function which will get all the relevant data (Table it occurred in, PC) and give the host a choice of returning or not.

@qookei
Copy link
Member

qookei commented Jul 26, 2019

Does AML on real hardware even use BreakPoint()? If no, why bother with it?

@thomtl
Copy link
Member

thomtl commented Jul 26, 2019

Its not exactly a very complicated opcode (just itself) and it would be nice to just have it. Also some people might run on Engineering bioses that might have them

@avdgrinten
Copy link
Member Author

IMHO we can just warn and ignore BreakPoint().

@thomtl
Copy link
Member

thomtl commented Jul 27, 2019

Alright, i'll have breakpoint up shortly, but fatal has termargs so imma figure that whole thing out

thomtl added a commit that referenced this issue Jul 27, 2019
@avdgrinten
Copy link
Member Author

Why do you skip 2 bytes after the breakpoint opcode? Did you add a unit test for this?

@avdgrinten
Copy link
Member Author

Fatal() can probably be handled as the other AML operators (e.g., Add()).

@thomtl
Copy link
Member

thomtl commented Jul 27, 2019

I did actually create a unit test, but im dumb, i'll fix it and push the unit test in a moment.

@thomtl thomtl closed this as completed in 9b08518 Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants