-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing opcode: Implement BreakPoint() and Fatal() #37
Comments
How should we handle a breakpoint? |
Does AML on real hardware even use BreakPoint()? If no, why bother with it? |
Its not exactly a very complicated opcode (just itself) and it would be nice to just have it. Also some people might run on Engineering bioses that might have them |
IMHO we can just warn and ignore BreakPoint(). |
Alright, i'll have breakpoint up shortly, but fatal has termargs so imma figure that whole thing out |
Why do you skip 2 bytes after the breakpoint opcode? Did you add a unit test for this? |
Fatal() can probably be handled as the other AML operators (e.g., Add()). |
I did actually create a unit test, but im dumb, i'll fix it and push the unit test in a moment. |
Add the missing opcode and a unit test.
The text was updated successfully, but these errors were encountered: