-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Use external freestanding headers implementation #859
Conversation
What does this PR fix? |
It is not a fix for anything. It makes mlibc rely on an external, more complete implementation of the freestanding C headers instead of its internal ones which were rather incomplete. |
How incomplete are they? |
Refer to |
as I mentioned before on discord, I approve of this idea but I do not have the means to verify the correctness of this particular implementation. I would say that the rationale is similar as with the |
Not against this. However, this would break Managarm if I'm not mistaken, can you prepare a PR for bootstrap-managarm too? |
@Dennisbonke see bootstrap-managarm#232 |
I'd prefer then that we just embed the external headers into mlibc then. Are they really so complex and change so often that we should rely on an external repository? Seems better to me to just add the missing parts to mlibc. |
You make a compelling point, honestly. You can freely copy my freestanding headers licensed under the 0BSD license into mlibc if you want. The idea of this PR is more about making it work similarily to linux-headers and ensuring that changes and new addition to the freestanding headers are "automatically" reflected. The freestanding headers are usually modified or changed to support new language standards and features, but you're right in that this is not something that happens all the time and it can be easily backported to the mlibc tree itself. |
Sorry it's taken me so long to get back to this. I agree that it would be useful to have the freestanding headers automatically updated. Currently mlibc doesn't have a unified way of dealing with external packages (tracked in issue #601). I propose that until we have that issue in order this PR instead copies the new freestanding headers into the current tree, and we make a new issue to make sure we don't forget that we need to keep it in sync. Then once we figured out a good way to keep third party code in sync we can change it over to the external repo. Reason I'm saying this is because as it stands this PR would add some annoyance to the developer workflow, which I'd rather avoid for now. |
No description provided.