This repository has been archived by the owner on Oct 3, 2019. It is now read-only.
Allow audience verification override #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbriancon
reviewed
Jan 9, 2018
mbq/tokens/decoder.py
Outdated
| @@ -31,7 +31,7 @@ def __init__(self, certificate=None, allowed_audiences=None): | |||
|
|
|||
| self._allowed_audiences = set(allowed_audiences) | |||
|
|
|||
| def decode(self, token): | |||
| def decode(self, token, verify_audience=True): | |||
There was a problem hiding this comment.
There's an argument here that we shouldn't allow users of mbq.tokens to shoot themselves in the foot or knowingly avoid checking the audience because it's "easier."
Another approach would be to provide a separate method Decoder.decode_foreign_token (with a better name) that has the same functionality but doesn't give the caller the impression that they can use it whenever they want a more relaxed decoder.
There was a problem hiding this comment.
Updated, totally open to suggestions on the name!
mattbriancon
approved these changes
Jan 9, 2018
tests/test_decoder.py
Outdated
| @@ -57,6 +57,16 @@ def test_decode_bad_audience(self): | |||
| with self.assertRaises(tokens.TokenError): | |||
| decoder.decode(make_jwt(audience='different_audience')) | |||
|
|
|||
| def test_decode_foreign_token(self): | |||
dursk
force-pushed
the
allow-to-skip-aud-verification
branch
from
8b8b8e2
to
1815b6f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for skipping audience verification when decoding
id_tokensforwarded from BFFs