Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream build should not update latest link for failed builds #420

Closed
jvlcek opened this issue Aug 19, 2014 · 5 comments
Closed

Upstream build should not update latest link for failed builds #420

jvlcek opened this issue Aug 19, 2014 · 5 comments
Assignees

Comments

@jvlcek
Copy link
Member

jvlcek commented Aug 19, 2014

See:

if File.exist?(link)

Need to add a check for FIle.zero?(the new images) or somethink

@jvlcek
Copy link
Member Author

jvlcek commented Aug 19, 2014

@cfme-bot assignee jvlcek

@jvlcek
Copy link
Member Author

jvlcek commented Sep 28, 2015

@miq-bot assign @simaishi

@miq-bot miq-bot assigned simaishi and unassigned jvlcek Sep 28, 2015
@carbonin
Copy link
Member

If this is still an issue it should probably be opened on the manageiq-appliance-build repo. @jvlcek @simaishi

@simaishi
Copy link
Contributor

Things will fail before that and doesn't get far enough to update symlink if something goes wrong, so we won't hit this issue in 'failed build' cases. But I guess you can get to that line with empty directory if you don't give any target to build...

@jvlcek
Copy link
Member Author

jvlcek commented Mar 10, 2016

I will close this.

@jvlcek jvlcek closed this as completed Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants