-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated btn's css #96
base: master
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for launchspacex ready! 🔨 Explore the source changes: e75e736 🔍 Inspect the deploy log: https://app.netlify.com/sites/launchspacex/deploys/60cc74103b543e0008725ecf 😎 Browse the preview: https://deploy-preview-96--launchspacex.netlify.app |
@harsh72835 there have been changes in the master branch, please pull the latest changes and update accordingly. |
we can change the font color right? |
@harsh72835 if it goes with the colour scheme of the website, sure. |
Okay |
.modal__hidden { | ||
display: none; | ||
.btn:hover { | ||
/* color: #fff; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary CSS lines can be removed altogether to avoid cluttering the code base
for other contributors.
display: none; | ||
.btn:hover { | ||
/* color: #fff; */ | ||
/* text-shadow: 1px 1px 1px #ffffffc7; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused text-shadow
property.
@@ -69,7 +69,8 @@ | |||
</div> | |||
<div class="links"> | |||
<a id="artlink" class="artlink" target="_blank" href="https://www.space.com/2196-spacex-inaugural-falcon-1-rocket-lost-launch.html"> | |||
<button class="btn youBtn">View Full Article</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must be using some code formatting tool and hence even for a minor CSS btn
adjustment, multiple lines have been modified. For future PRs
, you can try and avoid unnecessary code changes, otherwise, the PR
is great. :)
Description
I have styled the button with different style as per the used colors with their matching color palette.
Fixes #82
Type of Change:
added different colors in css file for btn class and pseudo class like :hover
How Has This Been Tested?
Checklist: