Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated btn's css #96

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

harsh72835
Copy link

Description

I have styled the button with different style as per the used colors with their matching color palette.

Fixes #82

Type of Change:

added different colors in css file for btn class and pseudo class like :hover

How Has This Been Tested?

  • on live server

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@netlify
Copy link

netlify bot commented Jun 17, 2021

✔️ Deploy Preview for launchspacex ready!

🔨 Explore the source changes: e75e736

🔍 Inspect the deploy log: https://app.netlify.com/sites/launchspacex/deploys/60cc74103b543e0008725ecf

😎 Browse the preview: https://deploy-preview-96--launchspacex.netlify.app

@manankohlii
Copy link
Owner

@harsh72835 there have been changes in the master branch, please pull the latest changes and update accordingly.
Also use a shade of yellow/orange instead of purple for button border

@harsh72835
Copy link
Author

we can change the font color right?

@manankohlii
Copy link
Owner

@harsh72835 if it goes with the colour scheme of the website, sure.

@harsh72835
Copy link
Author

Okay

.modal__hidden {
display: none;
.btn:hover {
/* color: #fff; */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary CSS lines can be removed altogether to avoid cluttering the code base for other contributors.

display: none;
.btn:hover {
/* color: #fff; */
/* text-shadow: 1px 1px 1px #ffffffc7; */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused text-shadow property.

@@ -69,7 +69,8 @@
</div>
<div class="links">
<a id="artlink" class="artlink" target="_blank" href="https://www.space.com/2196-spacex-inaugural-falcon-1-rocket-lost-launch.html">
<button class="btn youBtn">View Full Article</button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must be using some code formatting tool and hence even for a minor CSS btn adjustment, multiple lines have been modified. For future PRs, you can try and avoid unnecessary code changes, otherwise, the PR is great. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniform button style and font
3 participants