Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: exclude images in dark mode #308

Merged
merged 1 commit into from Jun 11, 2020
Merged

PDF: exclude images in dark mode #308

merged 1 commit into from Jun 11, 2020

Conversation

HollowMan6
Copy link
Contributor

@HollowMan6 HollowMan6 commented Jun 11, 2020

When dark mode is on, after the whole pdf is inverted, this feature is achieved by reinverting the locations where images appear.

Examples:
image

@MatthewZMD MatthewZMD merged commit 80e2ed4 into emacs-eaf:master Jun 11, 2020
@MatthewZMD
Copy link
Member

MatthewZMD commented Jun 11, 2020

厉害,没想到这么快就实现了基本功能,下一步是丰富反转的颜色,可以参考EAF浏览器的dark-mode效果,最好可以和emacs当前主题的具体颜色联动起来

@MatthewZMD
Copy link
Member

我看你直接开始贡献了,很棒,但还是得走一下报名流程,详情请看学生如何报名

@HollowMan6
Copy link
Contributor Author

HollowMan6 commented Jun 11, 2020

厉害,没想到这么快就实现了基本功能,下一步是丰富反转的颜色,可以参考eaf-browser-dark-mode,最好可以和emacs当前主题的具体颜色联动起来

好的,了解!

我看你直接开始贡献了,很棒,但还是得走一下报名流程,详情请看学生如何报名

OK,我申请书还没开始写,马上就准备开始。另外我想问一下我们这个整个EAF项目的ID是什么,因为报名的时候需要这个ID,但是在官网我只看到小项目的ID。
image

@MatthewZMD 谢谢!

@MatthewZMD
Copy link
Member

OK,我申请书还没开始写,马上就准备开始。另外我想问一下我们这个整个EAF项目的ID是什么,因为报名的时候需要这个ID,但是在官网我只看到小项目的ID。

你直接选择一个小项目的ID就行了

@HollowMan6
Copy link
Contributor Author

好的,谢谢!

@manateelazycat
Copy link
Member

非常厉害,感谢您的贡献,加油

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants