Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Browser: Add CSS based Adblock plugin #336 #337

Merged
merged 5 commits into from Jul 13, 2020

Conversation

HollowMan6
Copy link
Contributor

Fix bug when closing buffer:

Traceback (most recent call last):
  File "/home/mt/.emacs.d/site-elisp/emacs-application-framework/app/browser/buffer.py", line 66, in set_adblocker
    self.buffer_widget.load_adblocker()
  File "/home/mt/.emacs.d/site-elisp/emacs-application-framework/core/browser.py", line 107, in load_adblocker
    self.load_css(os.path.join(os.path.dirname(__file__), "adblocker.css"),'adblocker')
  File "/home/mt/.emacs.d/site-elisp/emacs-application-framework/core/browser.py", line 98, in load_css
    self.web_page.runJavaScript(SCRIPT, QWebEngineScript.ApplicationWorld)
RuntimeError: wrapped C/C++ object of type BrowserPage has been deleted

Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
…dblocker

Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
@manateelazycat manateelazycat merged commit 991ec61 into emacs-eaf:master Jul 13, 2020
@MatthewZMD
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants