Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF-Viewer: Add restriction to PDF files only #314 #356

Merged
merged 2 commits into from Jul 31, 2020

Conversation

HollowMan6
Copy link
Contributor

https://github.com/manateelazycat/emacs-application-framework/blob/83a25b83c4fc831a73a16dcdb617446a09c29507/app/pdf-viewer/buffer.py#L331

image

Since pymupdf doesn't support changing epub file's background currently, I add restriction so that page.drawRect only executes in the pdf files to solve #314 .

Signed-off-by: Hollow Man hollowman186@vip.qq.com

Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
@manateelazycat
Copy link
Member

python有获取扩展名的api,不要用split方法

Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
@HollowMan6
Copy link
Contributor Author

python有获取扩展名的api,不要用split方法

OK,已经更新

@MatthewZMD MatthewZMD merged commit 0cf6c7b into emacs-eaf:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants