-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill remote process #953
Merged
manateelazycat
merged 9 commits into
manateelazycat:master
from
werhner:kill-remote-process
Jun 9, 2024
Merged
Kill remote process #953
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0bf8079
kill remote lsp-bridge process when emacs exits
werhner 4e8b04e
middle completion expand for codeium
werhner 9be39c6
pass ssh exception
werhner b98661e
add ctags find def backend
werhner d53880b
add ctags max candidates
werhner e20666b
fixup local ctags complete
werhner 7e5ce49
rename acm-backend-ctags-max-candidates
werhner 9baf901
ajust code
werhner e23f3fc
move ctags to acm-backend-ctags.el
werhner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -793,12 +793,17 @@ def tabnine_complete(self, before, after, filename, region_includes_beginning, r | |
self.tabnine.complete(before, after, filename, region_includes_beginning, region_includes_end, max_num_results) | ||
|
||
@threaded | ||
def ctags_complete(self, symbol, filename, cursor_offset): | ||
self.ctags.make_complete(symbol, filename, cursor_offset) | ||
def ctags_complete(self, symbol, filename, max_lines, cursor_offset): | ||
self.ctags.make_complete(symbol, filename, max_lines, cursor_offset) | ||
|
||
@threaded | ||
def ctags_find_def(self, symbol, filename): | ||
self.ctags.find_definition(symbol, filename) | ||
|
||
def copilot_complete(self, position, editor_mode, file_path, relative_path, tab_size, text, insert_spaces): | ||
self.copilot.complete(position, editor_mode, file_path, relative_path, tab_size, text, insert_spaces) | ||
|
||
@threaded | ||
def codeium_complete(self, cursor_offset, editor_language, tab_size, text, insert_spaces, prefix, language): | ||
self.codeium.complete(cursor_offset, editor_language, tab_size, text, insert_spaces, prefix, language) | ||
|
||
|
@@ -828,7 +833,13 @@ def handle_server_process_exit(self, server_name): | |
log_time("Exit server {}".format(server_name)) | ||
del LSP_SERVER_DICT[server_name] | ||
|
||
def close_client(self): | ||
for client in self.client_dict.values(): | ||
if hasattr(client, "kill_lsp_bridge_process"): | ||
client.kill_lsp_bridge_process() | ||
|
||
Comment on lines
+836
to
+840
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not add close_client code to function "cleanup" ? |
||
def cleanup(self): | ||
self.close_client() | ||
"""Do some cleanup before exit python process.""" | ||
Comment on lines
+842
to
843
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. close_client should move to below of function comment |
||
close_epc_client() | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate code?