Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple "executablePath" from "IconLocation" inside "VM-Install-Shortcut" #842

Closed
emtuls opened this issue Jan 17, 2024 · 2 comments · Fixed by #845
Closed

Decouple "executablePath" from "IconLocation" inside "VM-Install-Shortcut" #842

emtuls opened this issue Jan 17, 2024 · 2 comments · Fixed by #845
Assignees
Labels
💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed

Comments

@emtuls
Copy link
Member

emtuls commented Jan 17, 2024

What's the problem?

Right now, we are forced to use the icon of whatever is set as the "executablePath" as that is what is passed in for the argument -iconLocation.

What if we would like to use a different icon located somewhere else or one that is not the executable we are using for the shortcut we are creating?

This came up when exploring ways to create a shortcut for cyberchef as I noticed that I am forced into providing a path to google chrome as an executablePath argument in order for the function to use it's icon.

I propose having a separate argument for IconLocation that we can pass into VM-Install-Shortcut ourselves which would alleviate this issue.

Steps to Reproduce

Try to create a console app shortcut using VM-Install-Shortcut with an executable used that is different than the icon you would like the shortcut to have.

@emtuls emtuls added 🐛 bug Something isn't working ❔ discussion Further discussion is needed labels Jan 17, 2024
@emtuls emtuls added 💎 enhancement It is working, but it could be better and removed 🐛 bug Something isn't working labels Jan 17, 2024
@Ana06
Copy link
Member

Ana06 commented Jan 17, 2024

I think this is a good idea!

@emtuls
Copy link
Member Author

emtuls commented Jan 17, 2024

Will make this modification after #840 is merged to avoid merge conflicts. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants