Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Signature Verification to the Code to fix issue 828 #1008

Closed
wants to merge 1 commit into from

Conversation

AmandineGagnon
Copy link

I attempted to fix the Issue #828 by adding the VM-Assert-Signature function to the code. This is my first pull request, so let me know if anything need to be changed or modified to be compliant with the process and coding guide.

Copy link

google-cla bot commented Apr 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmandineGagnon thanks for the work you put in this PR. Packages using signature verification are not the easiest to start with 😅

I recommend you to at least check the following pages from our documentation:

Important things to notice:

  • you need to accept the Google CLA for us to be able to merge the PR
  • when modifying a package, you need to increase the version with the format specified in the documentation
  • the package needs to create shortcut in the Tools directory using a category (as it was done before the update, but using the VM-Install-Shortcut helper directly as this was previously done inside the VM-Install-With-Installer helper function)
  • The CI will run several checks (like the linter which you can also run locally and the Google CLI check) and all of them need to succeed to be able to merge the PR.

Let us know if you have questions.

@Ana06 Ana06 requested a review from a team April 25, 2024 12:37
@Ana06 Ana06 added 🐛 bug Something isn't working 🌀 COMMANDO-VM A package or future to be used by COMMANDO VM labels Apr 29, 2024
@emtuls
Copy link
Member

emtuls commented Jun 14, 2024

Closing as it has been fixed in #1091 now.

@emtuls emtuls closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌀 COMMANDO-VM A package or future to be used by COMMANDO VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants