rules: reformat all rules using capafmt #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
williballenthin
commented
Jun 25, 2020
anti-analysis/anti-debugging/detect-debugging/peb-BeingDebugged.yml
Outdated
Show resolved
Hide resolved
williballenthin
commented
Jun 25, 2020
williballenthin
commented
Jun 25, 2020
|
i think these updates look really quite reasonable, and would recommend merging. |
mr-tz
reviewed
Jun 25, 2020
| - match: loop | ||
| - optional: | ||
| - number: 2 | ||
| - number: 3 | ||
| - number: 4 | ||
| - number: 6 | ||
| - number: 0xF | ||
| - string: "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/" | ||
| - string: ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/ |
There was a problem hiding this comment.
How does it know to remove the " here?
There was a problem hiding this comment.
must have intimate knowledge of the yaml spec to understand that this string does not need to be escaped/enclosed?
in other places, it does a good job of detecting when quotes are needed.
mr-tz
reviewed
Jun 25, 2020
mr-tz
reviewed
Jun 25, 2020
| - api: Foo32.bar | ||
| rule: | ||
| meta: | ||
| name: example |
There was a problem hiding this comment.
can this rule be removed?
There was a problem hiding this comment.
yes, sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.