Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce variable DESCRIPTION_SEPARATOR #87

Closed
Ana06 opened this issue Jul 3, 2020 · 0 comments · Fixed by #115
Closed

Introduce variable DESCRIPTION_SEPARATOR #87

Ana06 opened this issue Jul 3, 2020 · 0 comments · Fixed by #115
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ana06
Copy link
Member

Ana06 commented Jul 3, 2020

rather than using an inline string ' = ' that is prone to typo and cannot be used with "find references", use a constant like DESCRIPTION_SEPARATOR = "' = "' and use this throughout the code. (from @williballenthin's comment in #39)
@Ana06 Ana06 added enhancement New feature or request good first issue Good for newcomers labels Jul 3, 2020
williballenthin added a commit that referenced this issue Jul 6, 2020
@williballenthin
rules: factor out DESCRIPTION_SEPARATOR into a constant
ca175f0 
closes #87
@williballenthin williballenthin mentioned this issue Jul 6, 2020
Merged
@mr-tz mr-tz closed this as completed in #115 Jul 7, 2020
mr-tz added a commit that referenced this issue Jul 7, 2020
@mr-tz
Merge pull request #115 from fireeye/fix-102
f35263f 
#102 #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#102 #87 mandiant/capa
2 participants
@williballenthin @Ana06