Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SMDA backend #1213

Merged
merged 3 commits into from
Jan 4, 2023
Merged

remove SMDA backend #1213

merged 3 commits into from
Jan 4, 2023

Conversation

williballenthin
Copy link
Collaborator

closes #1062

this is a breaking change. it should land in v5.0. i'm not sure if we should merge before then, as it would preclude any further 4.x releases?

@williballenthin williballenthin added the breaking-change introduces a breaking change that should be released in a major version label Dec 6, 2022
@williballenthin williballenthin added this to the 5.0.0 milestone Dec 6, 2022
mr-tz
mr-tz approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a new release out either in Dec or Jan. We can merge this before then. My hope is to get a few other improvements in.

In the meantime, should we xfail the smda tests?

@williballenthin williballenthin added the dont merge Indicate a PR that is still being worked on label Dec 7, 2022
@mr-tz
Copy link
Collaborator

mr-tz commented Jan 3, 2023

Should we merge this in @williballenthin?

@williballenthin williballenthin removed the dont merge Indicate a PR that is still being worked on label Jan 4, 2023
@williballenthin williballenthin merged commit 94a712b into master Jan 4, 2023
@williballenthin williballenthin deleted the fix-1062 branch January 4, 2023 13:48
@williballenthin williballenthin mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

Assignees
No one assigned
Labels
breaking-change introduces a breaking change that should be released in a major version
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

remove SMDA backend
2 participants
@williballenthin @mr-tz