add more xor instructions #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mr-tz
commented
Dec 7, 2020
•
mr-tz
commented
- cover more XOR instructions
- force vivisect function at FVA in tests
mr-tz
force-pushed
the
fix/nzxor-xor-instructions
branch
from
c2ad6ab
to
4e099d6
Compare
mr-tz
force-pushed
the
fix/nzxor-xor-instructions
branch
from
4e099d6
to
4a215b8
Compare
tests/fixtures.py
Outdated
| @@ -223,13 +228,30 @@ def sample(request): | |||
| return resolve_sample(request.param) | |||
|
|
|||
|
|
|||
| def get_function(extractor, fva): | |||
| def get_function(extractor, fva, force=True): | |||
There was a problem hiding this comment.
i'm not a huge fan of how this function behaves implicitly (by creating the function if it doesn't exist, which doesn't match how capa works from the cli).
i'd recommend moving the make_function calls to a separate procedure, maybe invoked by the get_extractor function used by tests. this way, a user can easily find all the fixups we do to support testing.
There was a problem hiding this comment.
for example, within 3b13b_extractor(), check isinstance(extractor, VivisectExtractor) and if so, do the appropriate make_function calls before returning it.
mr-tz
force-pushed
the
fix/nzxor-xor-instructions
branch
from
4a215b8
to
72458e1
Compare
mr-tz
force-pushed
the
fix/nzxor-xor-instructions
branch
from
72458e1
to
08c3372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.