Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capa explorer support doc format #58

Merged
merged 4 commits into from
Jul 1, 2020

Conversation

mike-hunhoff
Copy link
Collaborator

Adding support for new doc format. Includes style changes and function/variable renaming to make code clearer.

New summary view:
snip1

New MITRE ATT&CK view:
snip2

Tree view now includes color/bold to highlight specific items:
Snip3

@mike-hunhoff mike-hunhoff added the enhancement New feature or request label Jul 1, 2020
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a lot of (maintenance) improvements, to be honest I didn't look through it much in detail, but trust your work and look forward to trying it out!

def info_to_name(s):
''' '''
def info_to_name(display):
""" extract root value from display name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we convert these docstrings for the entire project? Right now we use ''' throughout.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote yes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pycharm gives me a similar warning. i'm ok with this change, too.

triple-double quotes for docstrings
single quotes for strings

wonder if we can configure pycodestyle to check for this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williballenthin williballenthin merged commit 1a36f60 into master Jul 1, 2020
@williballenthin williballenthin deleted the capa-explorer-support-doc-format branch July 1, 2020 15:50
@williballenthin williballenthin mentioned this pull request Jul 1, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants