-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capa explorer support doc format #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a lot of (maintenance) improvements, to be honest I didn't look through it much in detail, but trust your work and look forward to trying it out!
def info_to_name(s): | ||
''' ''' | ||
def info_to_name(display): | ||
""" extract root value from display name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we convert these docstrings for the entire project? Right now we use ''' throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pycharm gives me a similar warning. i'm ok with this change, too.
triple-double quotes for docstrings
single quotes for strings
wonder if we can configure pycodestyle to check for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding support for new doc format. Includes style changes and function/variable renaming to make code clearer.
New summary view:
New MITRE ATT&CK view:
Tree view now includes color/bold to highlight specific items: